Skip to content

[HDInsight]Add some properties in some classes#18075

Merged
bquantump merged 1 commit intoAzure:masterfrom
aim-for-better:AddPrivateIPAddress
Jan 21, 2021
Merged

[HDInsight]Add some properties in some classes#18075
bquantump merged 1 commit intoAzure:masterfrom
aim-for-better:AddPrivateIPAddress

Conversation

@aim-for-better
Copy link
Copy Markdown
Member

@aim-for-better aim-for-better commented Jan 20, 2021 •
edited
Loading

The related Swagger Spec PR links are:
Azure/azure-rest-api-specs#12219
Azure/azure-rest-api-specs#12493

The main changes are bellow:

  • Add property "PrivateIPAddress" in the class ApplicationGetEndpoint.
  • Add property "PrivateIPAddress" in the class ConnectivityEndpoint.
  • Add properties "VmSizesWithEncryptionAtHost" and "VmSizeProperties" in the class BillingResponseListResult.
  • Add properties "ClusterHdpVersion", "StorageProfile" and "ExcludedServicesConfig" in the class ClusterGetProperties.
  • Add property "TenantId" in the class ClusterIdentityUserAssignedIdentitiesValue.
  • Add properties "Recommend" and "Default" in the class FilterMode.
  • Add property "EncryptDataDisks" in the class Role.
  • Add new classes Dimension, ExcludedServicesConfig, MetricSpecifications, OperationProperties, ServiceSpecification and VmSizeProperty.

@aim-for-better
Copy link
Copy Markdown
Member Author

aim-for-better commented Jan 20, 2021

Hi @allenjzhang @bquantump Could you please help review this PR? Thanks

@bquantump
Copy link
Copy Markdown
Member

bquantump commented Jan 20, 2021

Please ensure the following check list is completed:

https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#appendix-a-pr-review-checklist

@aim-for-better
Copy link
Copy Markdown
Member Author

aim-for-better commented Jan 21, 2021 •
edited
Loading

Please ensure the following check list is completed:

https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#appendix-a-pr-review-checklist

Hi @bquantump I have checked the checklist and updated the description to add related swagger spec PR links.
Now I am sure that all the checklist are done.
Could you please review it again?

@bquantump bquantump merged commit 65867a2 into Azure:master Jan 21, 2021
minnieliu pushed a commit to minnieliu/azure-sdk-for-net that referenced this pull request Jan 23, 2021
@aim-for-better
Add some properties in some classes (Azure#18075)
b283ec1 
Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

@m-nash m-nash Awaiting requested review from m-nash

@markcowl markcowl Awaiting requested review from markcowl

@nisha-bhatia nisha-bhatia Awaiting requested review from nisha-bhatia

@YalinLi0312 YalinLi0312 Awaiting requested review from YalinLi0312

1 more reviewer

@bquantump bquantump bquantump approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bquantump bquantump

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aim-for-better @bquantump